[PATCH] D65751: [LNT] Add support for v2 fmt in test data library

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 02:42:14 PDT 2019


thopre added a comment.

In D65751#1635200 <https://reviews.llvm.org/D65751#1635200>, @danilaml wrote:

> I see. It also looks like "run_order" was switched to `llvm_project_revision` for some reason (I couldn't quite get why - is it simply because the old schema used it? Seems not worth it even if it's hard to correct it in LNT), but if it won't change the behavior (i.e. produced reports) for existing LNT users then it's fine. There seems to be some confusion around what run order is supposed to be already.


I agree that run_order is a nicer name since one might want to use lnt for something else than llvm. But that ought to be done as a separate patch, this just allows producer to generate a v2 format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65751/new/

https://reviews.llvm.org/D65751





More information about the llvm-commits mailing list