[PATCH] D66803: [LV] Tail-folding with runtime memory checks

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 01:27:19 PDT 2019


SjoerdMeijer added a comment.

Hi,

Thanks for taking a look at this, and for clarifying this:

> The original intent was to make sure that under OptForSize only a single (vector) loop will be produced. I.e., w/o a scalar loop serving either as scalar leftover iterations or as runtime guard bailout.

and for pointing this out:

> There's another such assert in emitSCEVChecks(). Now that FoldTailByMasking no longer implies OptForSize this should indeed be updated (to use CM_ScalarEpilogueNotAllowedOptSize instead perhaps?).

Shall we address this separately in a different patch? I am looking at this now, and feel that I have embarked on a little SCEV adventure, and that this is a separate issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66803/new/

https://reviews.llvm.org/D66803





More information about the llvm-commits mailing list