[PATCH] D66849: [llvm-objdump] Add the missing ARMv8 subarch detection

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:360
+    case ARMBuildAttrs::v8_A:
+      Triple += "v8";
+      break;
----------------
Is "v8a" better?

There are a few other v8 build attributes:

  v8_R     = 15,  // e.g. Cortex R52
  v8_M_Base= 16,  // v8_M_Base AArch32
  v8_M_Main= 17,  // v8_M_Main AArch32
  v8_1_M_Main=21, // v8_1_M_Main AArch32

Should they be listed as well?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66849/new/

https://reviews.llvm.org/D66849