[PATCH] D61976: [PowerPC] Reorder CSR reloads in epilogue to follow the same order as CSR saves in the prologue

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 19:43:23 PDT 2019


jsji added a comment.

Are you still pursuing this Patch?



================
Comment at: llvm/lib/Target/PowerPC/PPCFrameLowering.cpp:2336
+  // the prologue as consecutive loads/stores in increasing order perform better
+  // on some PPC CPUs.
+  for (unsigned i = CSI.size(), e = 0; i-- != e;) {
----------------
Can you be more specific about `some PPC CPUs`? And how much better?
Have you tried other CPU? Any performance change for other CPU?
If this is not general better for all CPUs, have you considered at least add some options to revert to old order?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61976/new/

https://reviews.llvm.org/D61976





More information about the llvm-commits mailing list