[compiler-rt] r370110 - Fix asan-symbolize-bad-path.cpp on Darwin

Alexander Richardson via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 14:10:48 PDT 2019


Author: arichardson
Date: Tue Aug 27 14:10:47 2019
New Revision: 370110

URL: http://llvm.org/viewvc/llvm-project?rev=370110&view=rev
Log:
Fix asan-symbolize-bad-path.cpp on Darwin

I accidentally made the CHECK line stricter when committing D65322.
While it happens to work for Linux and FreeBSD, it broke on Darwin.
This commit restores the previous behaviour.

Modified:
    compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp

Modified: compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp?rev=370110&r1=370109&r2=370110&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp (original)
+++ compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp Tue Aug 27 14:10:47 2019
@@ -1,7 +1,8 @@
 // Test that asan_symbolize does not hang when provided with an non-existing
 // path.
 // RUN: echo '#0 0xabcdabcd (%t/bad/path+0x1234)' | %asan_symbolize | FileCheck %s -check-prefix CHECK-BAD-FILE
-// CHECK-BAD-FILE: #0 0xabcdabcd in ?? ??:0
+// Note: can't check for "0xabcdabcd in ?? ??:0" since DarwinSymbolizer will print the file even if it doesn't exist.
+// CHECK-BAD-FILE: #0 0xabcdabcd in
 // CHECK-BAD-FILE-EMPTY:
 
 // Also test that asan_symbolize doesn't assert on an invalid address with a valid file:




More information about the llvm-commits mailing list