[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 13:54:18 PDT 2019


dexonsmith added a comment.

In D66556#1647762 <https://reviews.llvm.org/D66556#1647762>, @dexonsmith wrote:

> In D66556#1646229 <https://reviews.llvm.org/D66556#1646229>, @aganea wrote:
>
> > This failed the build - I've changed `unix2dos` to `svn:eol-style CRLF` instead.
>
>
> Can we count on `tr` when we have `shell`?  If so, I suggest this instead:
>
>   // REQUIRES: shell
>   // RUN: tr '\n' '\r\n' <%s | %clang_cc1 -DOTHER -print-dependency-directives-minimized-source 2>&1 | FileCheck %s
>


Eh, nevermind, `tr` doesn't handle multi-character replacements.  Better to answer Alex's question.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66556/new/

https://reviews.llvm.org/D66556





More information about the llvm-commits mailing list