[PATCH] D65983: Autogenerate the shebang lines for tools/opt-viewer
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 27 11:21:53 PDT 2019
rnk added a comment.
How does this work at all? In llvm's lit.cfg.py I see this line:
opt_viewer_cmd = '%s %s/tools/opt-viewer/opt-viewer.py' % (sys.executable, config.llvm_src_root)
After this change, the referenced file does not exist.
I can probably update the path to refer into the object tree, but I'm wondering if there's a gap in testing somewhere.
If anyone is doing meaningful opt-viewer development, they might also want to consider separating most of the code out of the configured file so that they don't have to re-run cmake in order to test their changes.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65983/new/
https://reviews.llvm.org/D65983
More information about the llvm-commits
mailing list