[PATCH] D66443: [LifetimeAnalysis] Add [[gsl::Pointer]] to llvm::StringRef
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 27 11:12:27 PDT 2019
dexonsmith added a comment.
In D66443#1643395 <https://reviews.llvm.org/D66443#1643395>, @mgehre wrote:
> Generally, ArrayRef is also a candidate. But there we have the complication that OwningArrayRef indirectly inherits from ArrayRef. One is a gsl::Owner, the other a gsl::Pointer, and we
> need to make sure that we handle it correctly when OwningArrayRef is accessed through its base class which is then seen as a Pointer.
> I would thus defer this part to a later PR.
Can `OwningArrayRef` be changed not to inherit from `ArrayRef`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66443/new/
https://reviews.llvm.org/D66443
More information about the llvm-commits
mailing list