[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin added a comment.

In D66795#1646832 <https://reviews.llvm.org/D66795#1646832>, @arichardson wrote:

> Would it be possible to require a `const MCTargetOptions &Options` when creating MCAsmInfo?
>  If MCTargetOptions isn't always available, how about passing an `Optional<MCTargetOptions>` to MCAsmInfo? That would be equivalent to the current approach but make it harder to forget calling `adjustPrefixes()`


That would look something like this https://reviews.llvm.org/differential/diff/217420/ . I've already tested this solution earlier (except using Optional<>) but decided against it because of changes to MCAsmInfo for every target. Yes, the advantage is that it would be harder to forget about 'adjustPrefixes()' vs some more changes in code. Let me know which way you prefer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795