[PATCH] D66794: [WebAssembly] Add atomic.fence instruction

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/CodeGen/WebAssembly/atomic-fence.ll:7
 
 ; NOEMSCRIPTEN: LLVM ERROR: ATOMIC_FENCE is not yet supported in non-emscripten OSes
 
----------------
This line can be removed.


================
Comment at: llvm/test/CodeGen/WebAssembly/atomic-fence.ll:34
 ; CHECK-LABEL: singlethread_fence:
 ; CHECK-NOT:  compiler_fence
 define void @singlethread_fence() {
----------------
how about `CHECK-NOT: fence` to catch any kind of fence output?
Even better, could we also come up with some sequence of instructions that would otherwise be reordered (e.g. by register stackification) that the fence would prevent?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66794/new/

https://reviews.llvm.org/D66794