[PATCH] D43256: [MBP] Move a latch block with conditional exit and multi predecessors to top of loop

Tue Aug 27 07:40:38 PDT 2019

hans added a comment.

In D43256#1641893 <https://reviews.llvm.org/D43256#1641893>, @Carrot wrote:

> In D43256#1641056 <https://reviews.llvm.org/D43256#1641056>, @hans wrote:
>
> > In D43256#1639810 <https://reviews.llvm.org/D43256#1639810>, @xbolva00 wrote:
> >
> > > @hans this patch should be reverted from 9.0 I think so rc3 is “fixed”.
> >
> >
> > I'd rather see the fix land on trunk first (reverting on the branch is also not trivial, there are merge conflicts in several test files). From the discussion at http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190819/686087.html, it should be ready to go in again.
>
>
> It is committed as r369664.

I see there is a follow-up comment on the commit email saying it fails in the verifier.

I think at this point, we're too close to the llvm 9 release to take this. Hopefully it can get fixed and stabilized on trunk, and then be merged to llvm 9.0.1.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43256/new/

https://reviews.llvm.org/D43256