[PATCH] D66734: [llvm-readobj/llvm-readelf] - Report a proper warning when dumping a broken dynamic relocation.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM.



================
Comment at: test/tools/llvm-readobj/elf-broken-dynamic-reloc-name.test:14
+
+# GNU:      'RELA' relocation section at offset 0x278 contains 24 bytes:
+# GNU-NEXT: Offset           Info             Type          Symbol's Value   Symbol's Name + Addend
----------------
grimar wrote:
> jhenderson wrote:
> > I think the offset here is irrelevant, right? Can it be replaced with `{{.+}}`?
> Yes, done. BTW, I searched for "at offset" and noticed our tests are using `{{.*}}` for testing this line which is not entirely correct.
I think in most cases it probably doesn't matter either way, as we aren't really testing the printing of this line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66734/new/

https://reviews.llvm.org/D66734