[PATCH] D62327: [X86][CodeGen][NFC] Delay `combineIncDecVector()` from DAGCombine to X86DAGToDAGISel

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 05:37:50 PDT 2019


RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:3802
+
+  {
+    APInt Ones = APInt::getAllOnesValue(32);
----------------
(style) drop the braces?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:686
 
+    bool isConstantSplat(SDValue Op, APInt &SplatVal);
   } // end namespace X86
----------------
Add description comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62327/new/

https://reviews.llvm.org/D62327





More information about the llvm-commits mailing list