[PATCH] D66561: [X86] Remove encoding information from the TAILJMP instructions that are lowered by MCInstLowering. Fix LowerPATCHABLE_TAIL_CALL to also convert them to regular JMP/JCC instructions

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 02:15:37 PDT 2019


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM from the XRay parts.



================
Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1397
   unsigned OpCode = MI.getOperand(0).getImm();
+  OpCode = convertTailJumpOpcode(OpCode);
   MCInst TC;
----------------
craig.topper wrote:
> This line is the part in xray code, @dberris
Ah, right. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66561/new/

https://reviews.llvm.org/D66561





More information about the llvm-commits mailing list