[PATCH] D58540: [LLD][ELF][ARM] Accept and ignore -p and -no-pipeline-knowledge

Tue Aug 27 01:55:23 PDT 2019

peter.smith added a comment.

In D58540#1646340 <https://reviews.llvm.org/D58540#1646340>, @MaskRay wrote:

> The three places were removed https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=091bb549f7722723b284f63ac665e2aedcf9dec9
>
> > This has been a no-op in binutils since 2004 (see commit dea514f51da1 in that tree). Given that the lowest officially supported of binutils for the kernel is 2.20, which was released in 2009, nobody needs this flag around so just remove it. Commit 1a381d4a0a9a ("arm64: remove no-op -p linker flag") did the same for arm64.
>
> Maybe we can delete the the compatibility code in a future release, lld 10, or 11?

Sounds reasonable, I don't think that there is an existing community that have standardized a linux version and are varying their LLVM release on ARM, and I've not seen this option anywhere else. Having said that this does raise the issue of deprecation, in an ideal world when we want to take an option out in release N then we should have the option print a "This option is deprecated and will be removed from the next release." in release N - 1. That way we should flush out anyone depending on the option.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58540/new/

https://reviews.llvm.org/D58540