[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

[John McCall via Phabricator via llvm-commits]

rjmccall added inline comments.


================
Comment at: clang/docs/UsersManual.rst:1299
 
+.. option:: -fp-model=[values]
+
----------------
This should be something like `-fp-model=<value>`.  Square brackets mean optional elements in these docs.


================
Comment at: clang/docs/UsersManual.rst:1305
+   and ``noexcept``. Note that -fp-model=[no]except can be combined with the
+   other three settings for this option. Details:
+
----------------
Combined how?  With a comma?

This option seems to have two independent dimensions.  Is that necessary for command-line compatibility with ICC, or can we separate it into two options?

The documentation should mention the default behavior along both dimensions.  Is it possible to override a prior instance of this option to get this default behavior back?

You mention that this `-fp-model=fast` is equivalent to `-ffast-math`.  How does this option interact with that one if both are given on a command line?

Please put option text in backticks wherever it appears.

Most of these comments apply to `-fp-speculation` as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62731/new/

https://reviews.llvm.org/D62731