[PATCH] D66768: [lld][WebAssembly] Create optional symbols after handling --export/--undefined

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL370012: [lld][WebAssembly] Create optional symbols after handling --export/--undefined (authored by sbc, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D66768?vs=217243&id=217305#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66768/new/

https://reviews.llvm.org/D66768

Files:
  lld/trunk/test/wasm/Inputs/optional-symbol.ll
  lld/trunk/test/wasm/export-optional-lazy.ll
  lld/trunk/wasm/Driver.cpp


Index: lld/trunk/test/wasm/export-optional-lazy.ll
===================================================================
--- lld/trunk/test/wasm/export-optional-lazy.ll
+++ lld/trunk/test/wasm/export-optional-lazy.ll
@@ -0,0 +1,25 @@
+; Optional linker-synthetic symbols are only created if they are undefined
+; in the final output.
+; This test is for a regression where an explict --export of an lazy archive
+; symbol caused an undefined referece to an optional symbol to occur *after*
+; the optional symbols were created.
+
+; RUN: llc -filetype=obj %s -o %t.o
+; RUN: llc -filetype=obj %S/Inputs/optional-symbol.ll -o %t.a1.o
+; RUN: rm -f %t.a
+; RUN: llvm-ar rcs %t.a %t.a1.o
+; RUN: wasm-ld --export=get_optional %t.o %t.a -o %t.wasm
+; RUN: obj2yaml %t.wasm | FileCheck %s
+
+target triple = "wasm32-unknown-unknown"
+
+define void @_start() {
+entry:
+  ret void
+}
+
+; CHECK:      FunctionNames:
+; CHECK-NEXT:   - Index:           0
+; CHECK-NEXT:     Name:            _start
+; CHECK-NEXT:   - Index:           1
+; CHECK-NEXT:     Name:            get_optional
Index: lld/trunk/test/wasm/Inputs/optional-symbol.ll
===================================================================
--- lld/trunk/test/wasm/Inputs/optional-symbol.ll
+++ lld/trunk/test/wasm/Inputs/optional-symbol.ll
@@ -0,0 +1,7 @@
+target triple = "wasm32-unknown-unknown"
+
+ at __dso_handle = external global i8*
+
+define i8** @get_optional() {
+  ret i8** @__dso_handle
+}
Index: lld/trunk/wasm/Driver.cpp
===================================================================
--- lld/trunk/wasm/Driver.cpp
+++ lld/trunk/wasm/Driver.cpp
@@ -721,8 +721,6 @@
   if (errorCount())
     return;
 
-  createOptionalSymbols();
-
   // Handle the `--undefined <sym>` options.
   for (auto *arg : args.filtered(OPT_undefined))
     handleUndefined(arg->getValue());
@@ -742,6 +740,8 @@
             config->entry);
   }
 
+  createOptionalSymbols();
+
   if (errorCount())
     return;
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66768.217305.patch
Type: text/x-patch
Size: 1960 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190827/28ba4bab/attachment.bin>