[PATCH] D66409: [llvm-objcopy][MachO] Implement -Obinary

[Seiya Nuta via Phabricator via llvm-commits]

seiya marked an inline comment as done.
seiya added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp:531
+    return E;
+  memset(B.getBufferStart(), 0, TotalSize);
+
----------------
grimar wrote:
> Does it make sense to remove this in favor of speed?
> I.e. instead of filling the whole buffer with zeroes you can fill only gaps.
> This might be better for large binaries.
Updated the patch to fill only gaps instead of the whole buffer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66409/new/

https://reviews.llvm.org/D66409