[PATCH] D66405: [llvm-ifs] llvm Interface Stubs merging + object file generation tool.

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd added a comment.

Probably is worth having a test for the error case as well.



================
Comment at: llvm/test/tools/llvm-ifs/a.ifs:22
+# CHECK-ELF:   Type:                              DYN (Shared object file)
+# CHECK-ELF:   FUNC    GLOBAL DEFAULT  UND a
+# CHECK-ELF:   OBJECT  GLOBAL DEFAULT  UND b
----------------
Why are they undefined?


================
Comment at: llvm/test/tools/llvm-ifs/b.ifs:20
+# CHECK-ELF-NOT:   FUNC    GLOBAL DEFAULT  UND a
+# CHECK-ELF:   OBJECT  GLOBAL DEFAULT  UND b
+
----------------
Why undefined?


================
Comment at: llvm/test/tools/llvm-ifs/bd.ifs:1
+# RUN: llvm-ifs -a=write-ifs -o - %s %S/c.ifs %S/a.ifs | \
+# RUN: FileCheck %s --check-prefixes=CHECK-IFS2FUNC
----------------
Not sure what the value is of this test.  You already tested 1 file, and 1+ files.


================
Comment at: llvm/test/tools/llvm-ifs/c.ifs:1
+# RUN: llvm-ifs -a=write-ifs -o - %s %S/a.ifs | \
+# RUN: FileCheck %s --check-prefixes=CHECK-IFS2FUNC
----------------
Same.


================
Comment at: llvm/test/tools/llvm-ifs/class-template-specialization.ifs:1
+# RUN: llvm-ifs -a=write-ifs -o - %s | FileCheck %s --check-prefixes=CHECK-IFS
+
----------------
Okay, I suppose that this is C++.  At the very least, emit a TBD to ensure that the user label prefix is handled correctly.


================
Comment at: llvm/test/tools/llvm-ifs/ef.ifs:28
+# CHECK-ELF: OBJECT  GLOBAL DEFAULT  UND e
+# CHECK-ELF: OBJECT  GLOBAL DEFAULT  UND f
+
----------------
Why undefined


================
Comment at: llvm/test/tools/llvm-ifs/object.ifs:1
+# RUN: llvm-ifs -a=write-ifs -o - %s | FileCheck %s --check-prefixes=CHECK-IFS
+
----------------
Objects were already tested previously.


================
Comment at: llvm/test/tools/llvm-ifs/template-namespace-function.ifs:1
+# RUN: llvm-ifs -a=write-ifs -o - %s | FileCheck %s --check-prefixes=CHECK-IFS
+
----------------
Not sure what this is testing.


================
Comment at: llvm/test/tools/llvm-ifs/virtual.ifs:1
+# RUN: llvm-ifs -a=write-ifs -o - %s | FileCheck %s --check-prefixes=CHECK-IFS
+
----------------
Not sure what the virtuality testing is actually testing.


================
Comment at: llvm/test/tools/llvm-ifs/visibility.ifs:1
+# RUN: llvm-ifs -a=write-ifs -o - %s | FileCheck %s --check-prefixes=CHECK-IFS
+
----------------
Not sure if this is valuable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66405/new/

https://reviews.llvm.org/D66405