[PATCH] D66763: Ignore object files that lack coverage information. Before this change, if multiple binary files were presented, all of them must have been instrumented or the load would fail with coverage_map_error::no_data_found.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks, it should be fine to ignore the payload of the data_not_found error.



================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:317
+      }
+    }
     for (auto &Reader : CoverageReadersOrErr.get())
----------------
deansturtevant wrote:
> vsk wrote:
> > Could you simply check whether 'Readers' is empty after the loop, and return data_not_found if so? Then there's no need to update an Error object.
> That would change the logic so that passing in an empty ObjectFilenames would result in a data_not_found error. I'm not convinced that's the desired behavior, but would be willing to implement it if you think it is.
> 
> Please let me know what your preference is.
Sure, this should just create an error if ObjectFilenames is non-empty.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66763/new/

https://reviews.llvm.org/D66763