[PATCH] D66762: DAG: computeNumSignBits for MUL

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 13:57:02 PDT 2019


RKSimon requested changes to this revision.
RKSimon added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3719
+  case ISD::MUL: {
+    const unsigned TyBits = Op.getValueSizeInBits();
+
----------------
Can't we just use the VTBits variable? Also, getValueSizeInBits only works on scalar types.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66762/new/

https://reviews.llvm.org/D66762





More information about the llvm-commits mailing list