[PATCH] D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with minor comments.



================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:190
+  W.printNumber("SectionLength", AuxEntPtr->SectionLength);
+  // Unlike the corresponding fields in the section header, NumberOfRelocEnt
+  // and NumberOfLineNum do not handle values greater than 65535.
----------------
Newline before the comment.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:336
+    assert(NumberOfAuxEntries == 1 &&
+           "C_STAT symbol could only have 1 auxiliary entry.");
+    const XCOFFSectAuxEntForStat *StatAuxEntPtr;
----------------
s/could/should/;


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65240/new/

https://reviews.llvm.org/D65240