[PATCH] D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks for the patch. Could you elaborate on what you mean by OP_entry_value only being able to wrap a single byte? Skimming the implementation, the impression I get is that a full machine-reg-expression can be attached to an OP_entry_value (see: DwarfCompileUnit::addComplexAddress).



================
Comment at: llvm/test/DebugInfo/Mips/entry-value-non-empty-expr.ll:25
+; CHECK: DBG_VALUE {{.*}}, $noreg, {{.*}}, !DIExpression(DW_OP_plus_uconst, 32, DW_OP_stack_value)
+; CHECK-NOT: DBG_VALUE
+
----------------
Not sure if it's worth it here, but in general I find FileCheck's '-implicit-check-not=<pattern>' feature useful in situations like this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66746/new/

https://reviews.llvm.org/D66746