[PATCH] D65653: [AArch64] Change location of frame-record within callee-save area.

[Muhammad Omair Javaid via Phabricator via llvm-commits]

omjavaid reopened this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.

Hi

This rev breaks LLDB for AArch64. functionalities/thread/concurrent_events/* tests are failing after r368987.

The problem appears to be coming out of signal handling where linux might be assuming stack with previous layout of FP and LR pair.

Although AArch64 AAPCS does allow FP/LR to be implementation specific but this change might be breaking implementations which have adapted to previous layout.

I was wondering if this layout change is absolutely necessary for SVE accommodation?

AArch64 LLDB has a staging buildbot here: http://lab.llvm.org:8014/builders/lldb-aarch64-ubuntu


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65653/new/

https://reviews.llvm.org/D65653