[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

Mon Aug 26 11:26:10 PDT 2019

clayborg marked an inline comment as done.
clayborg added inline comments.

================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:102-103
+void InlineInfo::encode(FileWriter &O, uint64_t BaseAddr) const {
+  if (Ranges.empty())
+    return;
+  Ranges.encode(O, BaseAddr);
----------------
I think you are correct in that we should avoid calling this function in this case and have the user verify the data is good since this data will eventually be in a blob in the GSYM file that won't make sense to encode it at all of the data is not valid as it will just waste file space.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600