[PATCH] D66659: [DAGCombiner] Add node to the worklist in topological order in parallelizeChainedStores

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 10:56:09 PDT 2019


deadalnix added a comment.

Because the order in which nodes are traversed is not reliable, it is very hard to come up with a test for this. Ultimately, this is part of a larger body of work that intend to ensure nodes are processed in topological order by DAGCombiner. Even if they do not change the codegen, doing these changes are useful as they reduce the pressure on the logic that maintains the topological order.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66659/new/

https://reviews.llvm.org/D66659





More information about the llvm-commits mailing list