[PATCH] D66720: [LV] Fold tail by masking - handle reductions

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3690
+      for (User *U : VecLoopExitInst->users()) {
+        if ((Sel = dyn_cast<SelectInst>(U)))
+          break;
----------------
I think the assertions here could be a bit stronger, by additionally ensuring we only have a single SelectInst as user and all other users are PHINodes, instead of breaking once we find a SelectInst.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66720/new/

https://reviews.llvm.org/D66720