[PATCH] D66734: [llvm-readobj/llvm-readelf] - Report a proper warning when dumping a broken dynamic relocation.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3539
+  uint32_t SymIndex = R.getSymbol(Obj->isMips64EL());
+  const typename ELFT::Sym *Sym = Dumper->dynamic_symbols().begin() + SymIndex;
+  Expected<StringRef> ErrOrName = Sym->getName(Dumper->getDynamicStringTable());
----------------
MaskRay wrote:
> rupprecht wrote:
> > `using Elf_Sym = typename ELFT::Sym` at the start of this method should allow you to keep it like before (and is more idiomatic)
> ELFT::Sym is used once. I think it is fine to keep it as is.
I also came to this. We often use `using` or declaring vars when have multiple usings, but here we don't, so it would be one more line which we can avoid probably.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66734/new/

https://reviews.llvm.org/D66734