[PATCH] D65860: [Attributor] Add LoopInfo to InformationCache and improve willreturn deduction

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Does this affect any tests?



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:1523
+  /// Return true if a loop is known "maybe-endless".
+  virtual bool isKnownMaybeEndless(Loop &) const = 0;
+
----------------
Given that this already has an "AbstractState" you can put the implementations in this class.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2724
 void Attributor::identifyDefaultAbstractAttributes(
-    Function &F, DenseSet<const char *> *Whitelist) {
+    Function &F, LoopInfoMapTy& LoopInfoGetter,
+    DenseSet<const char *> *Whitelist) {
----------------
You don't seem to use it here. Do you plan to create an `AALoop` for each loop or one for a function? I guess the latter would allow to cache irreducible information as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65860/new/

https://reviews.llvm.org/D65860