[PATCH] D66734: [llvm-readobj/llvm-readelf] - Report a proper warning when dumping a broken dynamic relocation.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-broken-dynamic-reloc-name.test:31
+    Info:    0
+    Address: 0x0
+    Relocations:
----------------
MaskRay wrote:
> `Address` and `Info` can be deleted.
Right, removed.


================
Comment at: test/tools/llvm-readobj/elf-broken-dynamic-reloc-name.test:50
+ProgramHeaders:
+  - Type:  PT_LOAD
+    Sections:
----------------
MaskRay wrote:
> Is the PT_LOAD used?
Yeah. Otherwise here we'd have "Unable to parse DT_RELA: virtual address is not in any segment" error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66734/new/

https://reviews.llvm.org/D66734