[PATCH] D66682: Fix stack_trace_compressor builds for Clang < 6.0

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 06:37:30 PDT 2019


tejohnson added a comment.

In D66682#1644676 <https://reviews.llvm.org/D66682#1644676>, @sylvestre.ledru wrote:

> @tejohnson Nested if ? :)


I meant something like:
 if (...)

  if (...)

but in any case this wasn't the problem at all.

In D66682#1644869 <https://reviews.llvm.org/D66682#1644869>, @bjope wrote:

> FYI: I made a fixup here https://reviews.llvm.org/rL369891
>
> I see here that you suspect other problems (around usage of AND). The problem I solved was related to older cmake versions not supporting VERSION_GREATER_EQUAL.


Got it thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66682/new/

https://reviews.llvm.org/D66682





More information about the llvm-commits mailing list