[PATCH] D66682: Fix stack_trace_compressor builds for Clang < 6.0

Douglas Yung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 02:54:53 PDT 2019


dyung added a comment.

In D66682#1644676 <https://reviews.llvm.org/D66682#1644676>, @sylvestre.ledru wrote:

> @tejohnson Nested if ? :)
>
>   CMake Error at projects/compiler-rt/lib/gwp_asan/CMakeLists.txt:108 (if):
>     if given arguments:
>  
>       "COMPILER_RT_BUILD_LIBFUZZER" "AND" "(" "GNU" "STREQUAL" "Clang" ")" "AND" "CMAKE_CXX_COMPILER_VERSION" "VERSION_GREATER_EQUAL" "6.0"
>  
>     Unknown arguments specified
>  
>


We are seeing the same failure in our internal upstream builder using CMake 3.4.3.

Looking at the CMake documentation, the problem might be the use of VERSION_GREATOR_EQUAL.. It appears that binary test operator was not added to CMake until 3.7


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66682/new/

https://reviews.llvm.org/D66682





More information about the llvm-commits mailing list