[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Aug 25 23:51:17 PDT 2019
MaskRay added inline comments.
================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:103
+ if (Ranges.empty())
+ return;
+ Ranges.encode(O, BaseAddr);
----------------
Doesn't it need a few bytes to represent an empty `Ranges`? Or is it just unexpected to call encode on an empty `Ranges` (in this case an assert or llvm_unreachable might be better)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66600/new/
https://reviews.llvm.org/D66600
More information about the llvm-commits
mailing list