[PATCH] D66537: [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix marked 4 inline comments as done.
deadalnix added a comment.

Ok, I found a handful of cases that are not coevered by the test suite. I'll investigate if adding test coverage is possible, if it is do so. If not, then I'll remove any modification from that diff.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10968
         X = DAG.getNode(ISD::SIGN_EXTEND, SDLoc(N), VT, X);
-        AddToWorklist(X.getNode());
       } else if (OrigXWidth > VTWidth) {
----------------
This guy is not covered.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10979
         X = DAG.getNode(ISD::TRUNCATE, SDLoc(X), VT, X);
-        AddToWorklist(X.getNode());
       }
----------------
These guys are not covered either.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19198
                                   N0.getOperand(0), N1, N2);
-      AddToWorklist(NewOp.getNode());
       return DAG.getNode(ISD::INSERT_SUBVECTOR, SDLoc(N0.getNode()),
----------------
This is not covered either.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19503
                                   SCC.getOperand(4), Flags);
-      AddToWorklist(SETCC.getNode());
       SDValue SelectNode = DAG.getSelect(SDLoc(SCC), SCC.getValueType(), SETCC,
----------------
Not covered.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66537/new/

https://reviews.llvm.org/D66537