[PATCH] D66705: FileManager: Use llvm::Expected in new getFileRef API

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

In D66705#1644166 <https://reviews.llvm.org/D66705#1644166>, @dexonsmith wrote:

> Updated patch after running `check-clang` and learning more about `Expected`.  I've added a parallel API using `Optional<FileEntryRef>` for clients that don't want to do anything with the error.
>
> @lhames, is it reasonable to add `llvm::expectedToOptional`?


Absolutely: We've already got an errorToBool, so expectedToOptional makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66705/new/

https://reviews.llvm.org/D66705