[PATCH] D65240: [XCOFF][AIX] Generate symbol table entries with llvm-readobj
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Aug 24 07:49:58 PDT 2019
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:186
+ W.printNumber("SectionLength", AuxEntPtr->SectionLength);
+ W.printNumber("NumberOfRelocEnt", AuxEntPtr->NumberOfRelocEnt);
+ W.printNumber("NumberOfLineNum", AuxEntPtr->NumberOfLineNum);
----------------
hubert.reinterpretcast wrote:
> jasonliu wrote:
> > hubert.reinterpretcast wrote:
> > > Overflow handling is not here, and there is no TODO.
> > Discussed offline, the overflow handling is for section auxiliary header, not for symbol auxiliary entry.
> I've experimented with XLC, and confirmed that it does not do the overflow handling for these fields. It will populate these with the low bits of the logical value.
I think we can have a comment here that, unlike the corresponding fields in the section header, these fields do not handle values greater than 65535.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D65240/new/
https://reviews.llvm.org/D65240
More information about the llvm-commits
mailing list