[PATCH] D66642: [yaml2obj] - Don't allow setting StOther and Other/Visibility at the same time.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 24 06:42:42 PDT 2019


MaskRay added inline comments.


================
Comment at: lib/ObjectYAML/ELFEmitter.cpp:471
+    else if (Sym.StOther)
+      Symbol.st_other = *Sym.StOther;
+
----------------
jhenderson wrote:
> I just want to be clear that st_other is zero-initialized?
It is uninitialized.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66642/new/

https://reviews.llvm.org/D66642





More information about the llvm-commits mailing list