[PATCH] D66670: [AMDGPU] w/a for gfx908 mfma SrcC literal HW bug

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 12:01:41 PDT 2019


rampitec added a comment.

In D66670#1643378 <https://reviews.llvm.org/D66670#1643378>, @arsenm wrote:

> In D66670#1643370 <https://reviews.llvm.org/D66670#1643370>, @rampitec wrote:
>
> > In D66670#1643363 <https://reviews.llvm.org/D66670#1643363>, @arsenm wrote:
> >
> > > Can we have different opcodes with a different source type?
> >
> >
> > It will be a quite big change. What for?
>
>
> Generally if the operand/register class changes there should be a separate opcode. It avoids needing all this special case checking, and makes folding code work naturally


Anyway, you cannot have two opcodes with the same opcode without introducing a new encoding and a new decoder namespace. This bug will be fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66670/new/

https://reviews.llvm.org/D66670





More information about the llvm-commits mailing list