[PATCH] D66698: [ScopBuilder]Remove redundant while loop in ScopBuilder::buildDomains

bin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 19:45:15 PDT 2019


bin.narwal created this revision.
bin.narwal added reviewers: Meinersbur, Dominik_A.
bin.narwal added a project: Polly.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Hi,
The while loop iterating parent loop in ScopBuilder::buildDomains looks redundant, this is a simple patch removing it.  Is it OK?

Thanks,
bin


Repository:
  rPLO Polly

https://reviews.llvm.org/D66698

Files:
  lib/Analysis/ScopBuilder.cpp


Index: lib/Analysis/ScopBuilder.cpp
===================================================================
--- lib/Analysis/ScopBuilder.cpp
+++ lib/Analysis/ScopBuilder.cpp
@@ -831,10 +831,6 @@
   auto *S =
       isl_set_universe(isl_space_set_alloc(scop->getIslCtx().get(), 0, LD + 1));
 
-  while (LD-- >= 0) {
-    L = L->getParentLoop();
-  }
-
   InvalidDomainMap[EntryBB] = isl::manage(isl_set_empty(isl_set_get_space(S)));
   isl::noexceptions::set Domain = isl::manage(S);
   scop->setDomain(EntryBB, Domain);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66698.216999.patch
Type: text/x-patch
Size: 516 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190824/c9388151/attachment.bin>


More information about the llvm-commits mailing list