[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added a comment.

In D61675#1642206 <https://reviews.llvm.org/D61675#1642206>, @mcberg2017 wrote:

> Given that we may still want the binary fneg generated in Reassociate.cpp, this may be enough then, plus what was done in D66612 <https://reviews.llvm.org/D66612>.


Very difficult to tell. Reassociate is tricky (for me at least). :/

I'm throwing some obvious unary FNeg tests at it and they are working fine, compared against the equivalent binary FNeg tests. So I'm feeling fairly confident in general.

I could check in the tests if desired, but they're more like fuzz tests than targeting specific features of Reassoc. It would be hard to prove these new tests are not doubling coverage of some existing test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675