[PATCH] D66514: GlobalISel/TableGen: Handle setcc patterns

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:3534
+        DefInit *DI = dyn_cast<DefInit>(SrcChild->getLeafValue());
+        if (!DI || !DI->getDef()->isSubClassOf("CondCode"))
+          return failedImport("Unable to handle CondCode");
----------------
paquette wrote:
> Can we test this?
Pull out `DI->getDef()` into a variable?


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:3534-3535
+        DefInit *DI = dyn_cast<DefInit>(SrcChild->getLeafValue());
+        if (!DI || !DI->getDef()->isSubClassOf("CondCode"))
+          return failedImport("Unable to handle CondCode");
+
----------------
Can we test this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66514/new/

https://reviews.llvm.org/D66514