[PATCH] D66660: [ARM][ParallelDSP] Change search for muls

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 13:31:17 PDT 2019


efriedma added inline comments.


================
Comment at: lib/Target/ARM/ARMParallelDSP.cpp:655
+    InsertAfter = cast<Instruction>(Acc);
+  }
   IntegerType *Ty = IntegerType::get(M->getContext(), 32);
----------------
Maybe add LLVM_DEBUG logging to note the unpaired multiplies?

Should we move the `Acc = ConstantInt::get([...]` code below this loop, to avoid creating an unnecessary `add i32 %foo, 0`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66660/new/

https://reviews.llvm.org/D66660





More information about the llvm-commits mailing list