[PATCH] D66677: [GlobalISel] Introduce a G_DYN_STACKALLOC opcode to represent dynamic allocas

[Amara Emerson via Phabricator via llvm-commits]

aemerson marked 2 inline comments as done.
aemerson added inline comments.


================
Comment at: llvm/include/llvm/Target/GenericOpcodes.td:195
+  let InOperandList = (ins type1:$size, i32imm:$align);
+  let hasSideEffects = 0;
+}
----------------
arsenm wrote:
> Should this be considered a side effect?
I don't think so? G_FRAME_INDEX doesn't have side effects, so I don't think this should be counted as having it either. I do intend to use this to implement stack checking calls but that's a target dependent thing.


================
Comment at: llvm/test/MachineVerifier/test_g_dyn_stackalloc.mir:2
+# RUN: not llc -march=aarch64 -o /dev/null -run-pass=none -verify-machineinstrs %s 2>&1 | FileCheck %s
+# REQUIRES: global-isel, aarch64-registered-target
+
----------------
arsenm wrote:
> REQUIRES: global-isel isn't necessary anymore
Ok.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66677/new/

https://reviews.llvm.org/D66677