[PATCH] D66355: [COFF] Add libcall symbols to the link when LTO is being used.

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 12:53:43 PDT 2019


rnk added a comment.

In D66355#1642467 <https://reviews.llvm.org/D66355#1642467>, @hans wrote:

> In D66355#1637842 <https://reviews.llvm.org/D66355#1637842>, @rnk wrote:
>
> > lgtm
>
>
> You wrote lgtm, but it says changes required. And it looks like it landed in r369694.


Oops.

> Someone asked about merging this to the relaese_90 branch. What do you think?

I think we should do it. Ultimately, this is porting some well-tested logic from ELF back to COFF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66355/new/

https://reviews.llvm.org/D66355





More information about the llvm-commits mailing list