[PATCH] D66537: [DAGCombiner] Remove a bunch of redundant AddToWorklist calls.
Amaury SECHET via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 23 12:10:53 PDT 2019
deadalnix added a comment.
In D66537#1643292 <https://reviews.llvm.org/D66537#1643292>, @lebedev.ri wrote:
> I'm not sure how (if at all) to review patches like this?
> Just accept that none of the existing tests change and the diff seems sane?
I'm not sure what is the policy specifically for LLVM. This is what I would do. The fact that no test case change and they are all passing is a confirmation that these addition are indeed redundant (or possibly that tests cases are missing, but it doesn't looks like it in this case).
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66537/new/
https://reviews.llvm.org/D66537
More information about the llvm-commits
mailing list