[PATCH] D66661: [DAGCombiner] Add node to the worklist in topological order in scalarizeExtractedVectorLoad

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix marked 2 inline comments as done.
deadalnix added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1696
     if (RV.getNode() == N)
       continue;
 
----------------
When the node itself is returned, it is not added back to the worklist.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:16639
   ++OpsNarrowed;
   return SDValue(EVE, 0);
 }
----------------
lebedev.ri wrote:
> Won't this cause the node to be revisited, before `AddToWorklist(EVE);` ?
No. The only difference between this and just returning an empty value is that it increment the counter of transform that has been done. The main loop assumes that whatever transform does this has handled the worklist properly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66661/new/

https://reviews.llvm.org/D66661