[PATCH] D66443: [LifetimeAnalysis] Add [[gsl::Pointer]] to llvm::StringRef

Matthias Gehre via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 12:01:41 PDT 2019


mgehre added a comment.

Generally, ArrayRef is also a candidate. But there we have the complication that OwningArrayRef indirectly inherits from ArrayRef. One is a gsl::Owner, the other a gsl::Pointer, and we
need to make sure that we handle it correctly when OwningArrayRef is accessed through its base class which is then seen as a Pointer.
I would thus defer this part to a later PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66443/new/

https://reviews.llvm.org/D66443





More information about the llvm-commits mailing list