[PATCH] D66608: [InstCombine] icmp eq/ne (gep inbounds P, Idx..), null -> icmp eq/ne P, null

[Philip Reames via Phabricator via llvm-commits]

reames marked 4 inline comments as done.
reames added a comment.

A vector extension of this is now posted for review: https://reviews.llvm.org/D66671



================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:900
+  } else if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) &&
+             GEPLHS->getType()->isPointerTy() && // TODO: extend to vector geps
+             isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() &&
----------------
xbolva00 wrote:
> isa<ConstantPointerNull>(...)
Left as is for the vector patch now posted.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66608/new/

https://reviews.llvm.org/D66608