[PATCH] D66617: [llvm-dlltool] Make sure to strip decorations from ExtName for renamed exports

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 10:19:21 PDT 2019


mstorsjo added a comment.

In D66617#1643092 <https://reviews.llvm.org/D66617#1643092>, @jacek wrote:

> Oh, I see. FWIW, it shouldn't be too hard to work around the problem in Wine. .def file is generated automatically, so we could just skip aliases for .def file used for importlibs.


That sounds good

> and it might be better for LLVM to be MSVC compatible in this case

Well, when invoked as llvm-dlltool (or lld in mingw mode), it should definitely behave as the gnu equivalents. (Whether each bug is worth spending time on is ofc a different matter... And gnu dlltool has got an awful lot of different flags affecting how the symbol decorations are mangled.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66617/new/

https://reviews.llvm.org/D66617





More information about the llvm-commits mailing list