[PATCH] D61144: [LoopIdiomRecognize] BCmp loop idiom recognition

[Clement Courbet via Phabricator via llvm-commits]

courbet accepted this revision.
courbet added a comment.

LGTM. Maybe let's way a couple days to see if @reames has blocking issues ?



================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:228
+    Value *LoadSrcA, *LoadSrcB;
+    Value *LoadA_, *LoadB_;
+  };
----------------
Is there any reason for the trailing `_` ?


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:2578
+
+  // Finally fully DONE!
+  return DispatchBB;
----------------
rm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61144/new/

https://reviews.llvm.org/D61144